Repository navigation
Add Persian Subtitle Fixes plugin for SE5 - #305
Merged
Merged
Conversation
Port of msasanmh's Persian Subtitle Fixes (source/PersianErrors) to the SE5 plugin contract with an Avalonia UI: 12 rule groups with icons, Persian titles and live examples, per-line fix cards with highlighted differences, group filter chips, search, hidden-character display (ZWNJ, direction marks), selected-lines scope, apply and re-check, undo. The 1,526 rules are unchanged and run in the same order. Lines are returned as paragraphs, so every format is kept; line break style is preserved. Plain rules no longer get quotes escaped (the two quote + ZWNJ rules never matched before). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of msasanmh's Persian Subtitle Fixes (
source/PersianErrors) to the Subtitle Edit 5 plugin contract, with a new Avalonia UI.What's new
·, direction marks asRLE/RLM/..., and a changed line break as↵.Behaviour
multiple_replace.xmlare unchanged and run in the same order.subtitle.paragraphs(text only), so every format is kept. With an older SE, the plugin falls back to SubRip.\r\n, so text is converted for them and converted back. The line break style is kept, and the results are the same on macOS and Linux."+ ZWNJ plain rules never matched before.Tests
se5/PersianErrors.Tests, 32 tests:Checking 1,000 lines takes about 0.3 s.
Workflow:
persian-errors.yml(tagse5-persian-errors-vX.Y). Index entry follows after the first release run.🤖 Generated with Claude Code