-
-
Notifications
You must be signed in to change notification settings - Fork 16
Upgrade to Java 27 & small improvements #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
343b0dd
Updated to Java 27
MartelliEnrico d5bd90a
Added DEFAULT_TASK_NAME to JlinkTask
MartelliEnrico ec5acfd
Updated customWindowsStartScript.txt to latest version
MartelliEnrico 0036537
Added experimental mode to jspecify nullability checks
MartelliEnrico dab606c
Avoid the ffmpeg filters to use more than 1 CPU
MartelliEnrico aa296c5
Move download of jar to Gradle task
MartelliEnrico 7f7ead7
Code review changes
MartelliEnrico 5c9eba0
Fix IS_WINDOWS check
MartelliEnrico 45e671f
More code review fixes
MartelliEnrico d7cf7c1
Removed Qodana
MartelliEnrico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,4 +13,3 @@ LICENSE | |
| Dockerfile | ||
| *.dockerfile | ||
| Bumpfile | ||
| qodana.yaml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,3 @@ buildNumber.properties | |
| .idea/ | ||
| src/main/resources/*.png | ||
| .gradle/ | ||
| .qodana | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| .github/workflows/unit-test.yml | ||
| Dockerfile | ||
| qodana.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...dSrc/src/main/java/com/github/stickerifier/stickerify/DownloadOpenTelemetryAgentTask.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package com.github.stickerifier.stickerify; | ||
|
|
||
| import org.gradle.api.DefaultTask; | ||
| import org.gradle.api.file.RegularFileProperty; | ||
| import org.gradle.api.provider.Property; | ||
| import org.gradle.api.tasks.Input; | ||
| import org.gradle.api.tasks.OutputFile; | ||
| import org.gradle.api.tasks.TaskAction; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| import javax.inject.Inject; | ||
| import java.io.IOException; | ||
| import java.net.URI; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.StandardCopyOption; | ||
|
|
||
| public abstract class DownloadOpenTelemetryAgentTask extends DefaultTask { | ||
|
|
||
| public static final String DEFAULT_TASK_NAME = "downloadOpenTelemetryAgent"; | ||
|
|
||
| @Input | ||
| public abstract Property<@NotNull String> getVersion(); | ||
|
|
||
| @Input | ||
| public abstract Property<@NotNull Integer> getDownloadTimeoutMillis(); | ||
|
|
||
| @OutputFile | ||
| public abstract RegularFileProperty getDestinationFile(); | ||
|
|
||
| @Inject | ||
| public DownloadOpenTelemetryAgentTask() { | ||
| setGroup("distribution"); | ||
| setDescription("Downloads OpenTelemetry agent jar."); | ||
|
|
||
| getDownloadTimeoutMillis().convention(12000); | ||
| } | ||
|
|
||
| @TaskAction | ||
| public void downloadJar() throws IOException { | ||
| var version = getVersion().get(); | ||
| var urlString = "https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v%s/opentelemetry-javaagent.jar".formatted(version); | ||
| var targetFile = getDestinationFile().get().getAsFile(); | ||
|
|
||
| var _ = targetFile.getParentFile().mkdirs(); | ||
|
|
||
| var connection = URI.create(urlString).toURL().openConnection(); | ||
| int timeoutMillis = getDownloadTimeoutMillis().get(); | ||
| connection.setConnectTimeout(timeoutMillis); | ||
| connection.setReadTimeout(timeoutMillis); | ||
|
|
||
| try (var inputStream = connection.getInputStream()) { | ||
| Files.copy(inputStream, targetFile.toPath(), StandardCopyOption.REPLACE_EXISTING); | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,11 @@ | ||
| #This file is generated by updateDaemonJvm | ||
| toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/39e8ce74cee3e629d6fade20d237fff5/redirect | ||
| toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/b7f6da648647bf05d05a14cdca409f73/redirect | ||
| toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/39e8ce74cee3e629d6fade20d237fff5/redirect | ||
| toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/b7f6da648647bf05d05a14cdca409f73/redirect | ||
| toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/b5e76458e870841069679392d5855834/redirect | ||
| toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/ef59bf670a5688da71dc8f2e9d1f8b76/redirect | ||
| toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/39e8ce74cee3e629d6fade20d237fff5/redirect | ||
| toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/b7f6da648647bf05d05a14cdca409f73/redirect | ||
| toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/06340fb34ff0b1b2e0cde9562b75744e/redirect | ||
| #This file is generated by :updateDaemonJvm | ||
| toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/22fd4fd9a5dedf12964be0a987f4e90b/redirect | ||
| toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/c753409d258f3e09db9cfda022a8b52a/redirect | ||
| toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/22fd4fd9a5dedf12964be0a987f4e90b/redirect | ||
| toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/c753409d258f3e09db9cfda022a8b52a/redirect | ||
| toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/7857181a003a2064a9272111de852844/redirect | ||
| toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/22fd4fd9a5dedf12964be0a987f4e90b/redirect | ||
| toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/c753409d258f3e09db9cfda022a8b52a/redirect | ||
| toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/36c6fff412e42f23a647ccc8ac1ee8fe/redirect | ||
| toolchainVendor=ADOPTIUM | ||
| toolchainVersion=26 | ||
| toolchainVersion=27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
|
MartelliEnrico marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
src/main/java/com/github/stickerifier/stickerify/process/OsConstants.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.