Repository navigation
handle the origin type for solidos - #338
Open
SharonStrats wants to merge 1 commit into
Open
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
Prompt: dokeili's plans do not include origin, check for origin and create an origin plan following our existing logic in the acl directory for origins. we do not need originClass at this time Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dokeili's plans do not include origin in the same way as the other access types and in the way we do it in solidos. It is handled in a different way like this
so the agent is also tied to the origin. I am wondering if we should do it this way and add the user granting access as the agent?
Should we create a ticket for another release where we handle origins differently to other access types and allow a user to select an agent, agentGroup, agentClass to tie to the origin?
This PR adds origin access as we currently do now, but hides that from the consumer.