Repository navigation
Return early in setnafill to avoid accessing 0-row element - #7911
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7911 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 88 88
Lines 17376 17378 +2
=======================================
+ Hits 17206 17208 +2
Misses 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jangorecki
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7910.
The illegal access comes from here (ditto other input types, and
"nocb"):data.table/src/nafill.c
Line 26 in a3eeb4c
This doesn't (currently) happen for
type="const"because all accesses are in the trivialforloop there:data.table/src/nafill.c
Line 10 in a3eeb4c
Returning up-front is good for efficiency anyway, so don't bother trying to avoid those accesses -- just quit once 0-row input is detected.