Repository navigation
The simulator takes env_set from boarddev (lands with the wasm rebuild) - #5
Merged
Merged
Conversation
pydevices moved the env helpers from displaydev to boarddev with no re-export (a hard break). The simulator runs the vendored wasm with pydevices frozen in, so this lands with the wasm rebuild that freezes the new pydevices, not before.
The same build as the portal's (micropython-pydevices 59cb3bd): boarddev has the env helpers, which the simulator's boot now imports from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDevices/pydevices#131 moves the env helpers from displaydev to boarddev as a hard break. The simulator's boot (
src/pydevices/runtime.js) now takesenv_setfrom boarddev.This also vendors the runtime that import needs:
assets/pydevices/micropython.{mjs,wasm}rebuilt by micropython-pydevices at 59cb3bd, freezing pydevices 0.7.0. The two halves land together: the old runtime has noboarddev.env_set, and the new one has nodisplaydev.env_set. Its.provenancenames checkouts relative to the workspace, with no absolute home paths.Ran the browser suite against a full
python3 build.py --skip-testsbuild: 16 of 16 pass (boot installs nothing, REPL, every example paints, LVGL pointer, audio, resize, resets, timers). CI's run on this branch passes too; on the old runtime it failed every spec at connect.