Repository navigation
refactor(workflows)!: step 1, standardize workflow names and inputs - #38
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
… in the future) Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
…l optargs Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
725aa70 to
46b914c
Compare
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
c1caf9d to
3eb61f6
Compare
synackd
left a comment
There was a problem hiding this comment.
Lot of good refactoring here.
One other thing I thought of is that ubuntu-slim imposes a hard 15-minute job limit and one CPU on every caller and so I'm wondering if it would be worth it to add a string runner input defaulting to the current default runners (ubuntu-latest/ubuntu-latest), and use runs-on: ${{ inputs.runner }} to change from the default. Just a thought.
Yeah... I noticed that in the docs and don't agree with the disparity (single cpu => 15 minutes, anything else => 6 hours), but rules are rules I suppose. I'll make it parameterized as requested. Should I add any warnings? I've always been of the mindset that unit tests should only take a few minutes, while integration + e2e tests go for any sane number of hours. |
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
09941b8 to
e568377
Compare
Description
Do let me know if this needs to be split into multiple PRs. My intention is to target a
v4release due to the number of breaking changes.Note
I still need to do an interactive rebase to modify several commit names, shuffle the order around, and squash others for cleanliness.
Despite the upcoming VCS history changes, I recommend a rebase style merge unless this PR is split into multiple. The underlying changes are too diverse to reasonably crush into a single commit.
What this PR does:
ubuntu-slimrunners (workflows requiring the docker daemon are not eligible).lsorder)<workflow>-<variant>.ymlNote
This is a first step toward taming
What this PR does not do:
The only listed issue this fixes is: #35
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change