Repository navigation
TEDEFO-5239 Create the data types without an SDK version - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data types without an SDK version
TEDEFO-5239
A follow-up of #71. The data types come from the
data-types.jsonresource of this library, which is the same for SDK 1 and SDK 2: SDK 2's ownfields/fwd/data-types.jsonis not read yet (TEDEFO-5231). They do not depend on the SDK version, so creating them no longer needs one:new SdkDataTypeRepository()reads the resource, and creates plainSdkDataTypeobjects.SdkDataTypeRepository(String sdkVersion)is removed.SdkDataTypeV1,SdkDataTypeV2,SdkEntityFactory.getSdkDataTypeandSdkComponentType.DATA_TYPE, added in TEDEFO-5239 Provide the typed attribute and the code list of each data type #71 and never released, are removed:SdkEntityFactoryandSdkComponentTypeare back to their state in 1.9.1.createDefault()still returns the same 19 data types, with their masking values only. A new test checks that.Validation
mvn verify: all 99 tests pass, and so does the API compatibility check against 1.9.1.