Repository navigation
Add docs pages for GA4, Google Tag Manager, Converge, Hotjar and Make apps - #63
Merged
Merged
Conversation
…ge, Hotjar and Make apps Each page is written from the app's repo (manifest, README, tracker code, CHANGELOG) in the style of the existing app pages, and added to the Apps sidebar.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
nextcommerce-docs | a5c6cfd | Commit Preview URL Branch Preview URL |
Oct 07 2026, 09:02 AM |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Incremental re-review (since
|
| Severity | Count |
|---|---|
| CRITICAL | 0 |
| WARNING | 1 |
| SUGGESTION | 1 |
Issue Details (click to expand)
WARNING
| File | Line | Issue |
|---|---|---|
content/docs/apps/hotjar.mdx |
25 | "Hotjar" warning understates the failure mode: enabling tracking with no/empty Site ID produces a JS syntax error on every storefront page (per PR description), not just a missing Hotjar load. Should warn that the storefront can break. |
SUGGESTION
| File | Line | Issue |
|---|---|---|
content/docs/apps/converge.mdx |
53 | "Converge" should document the per-event tax inconsistency for Added To Cart (price excl. tax, line items incl. tax) so merchants reconciling Converge revenue against NEXT orders aren't surprised. |
Files Reviewed (6 files)
content/docs/apps/converge.mdx- 1 issuecontent/docs/apps/google-analytics-4.mdx- 0 issuescontent/docs/apps/google-tag-manager.mdx- 0 issuescontent/docs/apps/hotjar.mdx- 1 issuecontent/docs/apps/make.mdx- 0 issuescontent/docs/apps/meta.json- 0 issues
Reviewer Notes
- Both issues stem from the PR description itself, which authoritatively documents known app defects (Hotjar unquoted/unescaped Site ID injection, Converge add-to-cart price/line-item tax mismatch). The new pages do not yet surface these to merchants.
- All five new pages correctly link
/docs/manage/orders/test-orders, matching the convention inmeta-pixel.mdxandeverflow.mdx. meta.jsonalphabetization is consistent with the existing sidebar order.- Gaps the author already flagged and is tracking outside the PR (apps.json
links.docs, Shop Sync guide move, stale Make/Converge/Hotjar repos, Convergecheckout_completednull-guard, GTM missing from apps.json) are out of scope for this docs-only review and were not duplicated here. - Note: external calls to
api.github.com/repos/NextCommerceCo/*were rejected by the sandbox, so findings rely on the PR description and on-disk diff/file content as authoritative sources.
Reviewed by minimax-m3 · Input: 61.4K · Output: 3.5K · Cached: 501.8K
# Conflicts: # content/docs/apps/meta.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds user docs pages for first-party NEXT apps that are listed on nextcommerce.com/apps but had no docs page, and records docs coverage for every entry in the apps directory.
New pages, each written only from the app's repo (manifest, README, code, CHANGELOG), in the style of
klaviyo.mdxandmeta-pixel.mdx:apps/google-analytics-4main, 2026-09-07, CHANGELOG 0.8)apps/google-tag-managermain, 2026-09-07, CHANGELOG 1.9)apps/convergemain, 2026-02-17)apps/hotjarmain, 2022-10-27)apps/makemain, 2022-09-05)apps/meta.jsonadds all five to the sidebar. Taboola (separate refresh session) and Chargeback360/midigator.mdx(separate move) are deliberately untouched.Checks:
check-markup,validate-links,audit-developer-linksandcheck-capabilitiespass locally.Before merging
view_item_list/remove_from_cart/add_shipping_info, Skip Test Orders). If installs still run the pre-September versions, the pages are ahead of production.twentyninenext), so the page links out for them. Someone with access to the Make developer account should confirm the connection steps.Step 1: app coverage
Classification: NEXT (repo) = first-party app with a repo in NextCommerceCo; Core = built into oscar-prime (inspected, not changed); Partner = no repo in our org and no reference in oscar-prime. "Docs" is the state after this PR. Permissions are the NEXT OAuth scopes the app requests in code; storefront-only apps (settings + snippet + event tracker) request none.
First-party apps with a repo
google-analytics)apps/google-analytics-4global_header; event tracker maps 7 storefront events to GA4 (view_item_list…purchase) + Adsconversion. No OAuth.links.docsshould point at the new page (today it links the GitHub repo aswebsite). Deploy status of 0.8 unverified.apps/google-tag-managerglobal_header; tracker pushes 8dataLayerevents. No OAuth.window.top.dataLayer; code useswindow.parent(doc follows code). Description still says "29 Next Platform".converge)apps/convergeglobal_header($page_load); tracker: Viewed Product, Added To Cart, Started Checkout, Added Contact Info, Placed Order. No OAuth./pixels/.jsif enabled without a pixel code, and the pixel code is not escaped.checkout_completedreadsevent.data?.user.emailwithout a guard (throws ifuseris null). Added To Cart price is excl. tax, line items are incl. tax. README "Added Contact Info" link anchors to#added-payment-info. No CHANGELOG.hotjar)apps/hotjarglobal_headeronly; no event tracker. No OAuth.make)apps/makeapp_urlmake.com, redirect URIs on integromat.com. Scopes are requested by Make, not defined in the repo.shop-sync)develop)store:read webhooks:read/write catalogue:read/write metadata:read/write locations:write fulfillment_service:read/write orders:read/write users:read. NEXT webhooks: app.uninstalled, product.updated, customer.updated (+ fulfillment-service callbacks). Shopify scopes: read_products, read_inventory, read_locations, read/write_orders, write_customers, read_fulfillments, read_publications, read_merchant_managed_ and read_third_party_fulfillment_orders.docs/apps/shop-sync, which 404s: point it at the guide. See the Shop Sync section.klaviyo)develop)webhooks:read/write orders:read catalogue:read; webhooks: cart.abandoned, order.created/updated, subscription.created/updated, customer.created/updated/redacted, product.created/updated, fulfillment.updated, app.uninstalled. Storefront tracker +global_footersnippet.meta)develop)apps/meta-pixel)store:read webhooks:read/write orders:read metadata:write; webhooks: app.uninstalled, order.created, store.updated. Storefront tracker +global_headersnippet.gorgias)develop)webhooks:read/write users:read orders:read; webhooks: customer.created/updated, order.created/updated, app.uninstalled; plus Gorgias OAuth.3pl-central)develop)store:read webhooks:read/write admin:read fulfillment_service:read/write; webhook app.uninstalled; registers as a fulfillment service.admin:readin addition to scoped permissions. Not re-audited.develop)store:read webhooks:read/write orders:read orders:write; webhooks: app.uninstalled, order.updated, store.updated.taboola)parcellis)global_footeron checkout. No OAuth.apps/campaigns-app/)Core platform (oscar-prime)
All have a docs page except where noted. None needs an app page from this work.
features/payments/...features/payments/gateways/...features/payments/risk-screeningapps/shipstationapps/avalara-avatax,apps/taxjarapps/everflowapps/.build-a-store/catalogue/google-merchant-xml-feedapps/google-analytics-4.build-a-store/technical-settings/configure-webhooksPartner-built (needs partner input, owner: Brett)
No repo in NextCommerceCo and no reference in oscar-prime. Not documented from guesswork.
midigator.mdxmoveShop Sync
A full draft written from
developexists but is held back, because yesterday's shop-sync change moved the Shop Sync docs to the guides site. While reading the code, the draft found:start-here/get-started/support-and-notifications.mdx:31says refunds are handled in NEXT, but ondevelopa refund made in Shopify now creates a NEXT refund (NextCommerceCo/shop-sync#170, not in any changelog yet). Changelog 2025-01-08 says Shopify customer updates sync into NEXT, but the code only syncs NEXT to Shopify. Changelog 2026-03-20 says carriers are guessed "if the carrier is not set", but a fulfillment with no carrier sends no tracking.Follow-ups outside this repo
src/data/apps.json(NextCommerceCo/nextcommerce-site#194): setlinks.docsforgoogle-analytics,converge,hotjar,make; pointshop-syncat the guide instead of the 404; add a Google Tag Manager entry; consider Delivery Tracking and Campaigns App entries.