Skip to content

build: consume jclara and xmsg from code.jlab.org - #1498

Open
c-dilks wants to merge 2 commits into
developmentfrom
bump-jclara-and-xmsg
Open

c-dilks wants to merge 2 commits into
developmentfrom
bump-jclara-and-xmsg

Conversation

@c-dilks

@c-dilks c-dilks commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

xmsg changes

bumping JAR from 2.3 to our deployed version on code.jlab.org, which we have tagged as 2.5

From what I can tell, most of these changes are to gradle files and testing. The commits that stand out to me as being substantive source code changes are:

Here are the full diffs:

jclara changes

This is the CLARA we depend on at build time; we use a different version with run-clara.

It looks like we forked at commit 4b414bc7; I added the tag v4.3 to our fork at the same position as the upstream's v4.3, since it was missing, and I assume that this is the version the clasweb 4.3 JAR was deployed from.

Looking at the diff via the following command, I don't see any changes that will impact us, at least at first glance:

git diff v4.3..6.2 **/*.java

Here are the full difs:

additional changes

  • remove gson convergence conflict resolution; alert explicitly needs it at runtime though, so add it along with djl in its copy-dependencies execution, which ensures the correct gson version is used

@c-dilks c-dilks added the maven label Oct 9, 2026
@c-dilks
c-dilks marked this pull request as ready for review October 9, 2026 16:17
@c-dilks
c-dilks marked this pull request as draft October 9, 2026 18:58
@c-dilks
c-dilks marked this pull request as ready for review October 9, 2026 23:11
@baltzell
baltzell enabled auto-merge (squash) October 10, 2026 02:38
@baltzell
baltzell force-pushed the bump-jclara-and-xmsg branch from e7b6b65 to c2aad44 Compare October 10, 2026 02:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants