Repository navigation
Conversation
c-dilks
marked this pull request as ready for review
October 9, 2026 16:17
c-dilks
marked this pull request as draft
October 9, 2026 18:58
c-dilks
marked this pull request as ready for review
October 9, 2026 23:11
baltzell
approved these changes
Oct 10, 2026
baltzell
enabled auto-merge (squash)
October 10, 2026 02:38
baltzell
force-pushed
the
bump-jclara-and-xmsg
branch
from
October 10, 2026 02:38
e7b6b65 to
c2aad44
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xmsgchangesbumping JAR from
2.3to our deployed version oncode.jlab.org, which we have tagged as2.5From what I can tell, most of these changes are to
gradlefiles and testing. The commits that stand out to me as being substantive source code changes are:Here are the full diffs:
v2.3->v2.5: https://code.jlab.org/hallb/clas12/coatjava/xmsg-java/-/compare/v2.3...v2.5?from_project_id=959v2.3->masterbefore we forked tocode.jlab.org: JeffersonLab/xmsg-java@v2.3...3463809jclarachangesThis is the CLARA we depend on at build time; we use a different version with
run-clara.It looks like we forked at commit
4b414bc7; I added the tagv4.3to our fork at the same position as the upstream'sv4.3, since it was missing, and I assume that this is the version theclasweb4.3 JAR was deployed from.Looking at the diff via the following command, I don't see any changes that will impact us, at least at first glance:
Here are the full difs:
v4.3->6.2: https://code.jlab.org/hallb/clas12/coatjava/clara-java/-/compare/v4.3...6.2?from_project_id=243 (better to clone the repo and view locally...)additional changes
gsonconvergence conflict resolution;alertexplicitly needs it at runtime though, so add it along withdjlin itscopy-dependenciesexecution, which ensures the correctgsonversion is used