Skip to content

Require NumPy 2.5.4 in median/nanmedian empty kept-dim tests #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonwolfy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Require NumPy 2.5.4 in median/nanmedian empty kept-dim tests #3093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions dpnp/tests/test_nanfunctions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,19 +413,16 @@ def test_empty(self, axis, shape):
expected = numpy.nanmedian(a, axis=axis)
assert_dtype_allclose(result, expected)

@with_requires("numpy>=2.5.4")
@pytest.mark.usefixtures("suppress_mean_empty_slice_numpy_warnings")
@pytest.mark.parametrize(
"keepdims, out_shape", [(False, (0,)), (True, (0, 1, 1))]
)
def test_empty_kept_dim(self, keepdims, out_shape):
@pytest.mark.parametrize("keepdims", [False, True])
def test_empty_kept_dim(self, keepdims):
a = numpy.empty((0, 3, 4))
ia = dpnp.array(a)

result = dpnp.nanmedian(ia, axis=(1, 2), keepdims=keepdims)
assert result.shape == out_shape
if numpy_version() >= "2.5.4":
expected = numpy.nanmedian(a, axis=(1, 2), keepdims=keepdims)
assert_dtype_allclose(result, expected)
expected = numpy.nanmedian(a, axis=(1, 2), keepdims=keepdims)
assert_dtype_allclose(result, expected)

@pytest.mark.usefixtures("suppress_mean_empty_slice_numpy_warnings")
@pytest.mark.parametrize(
Expand Down
13 changes: 5 additions & 8 deletions dpnp/tests/test_statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,19 +944,16 @@ def test_empty(self, axis, shape):
expected = numpy.median(a, axis=axis)
assert_dtype_allclose(result, expected)

@with_requires("numpy>=2.5.4")
@pytest.mark.usefixtures("suppress_mean_empty_slice_numpy_warnings")
@pytest.mark.parametrize(
"keepdims, out_shape", [(False, (0,)), (True, (0, 1, 1))]
)
def test_empty_kept_dim(self, keepdims, out_shape):
@pytest.mark.parametrize("keepdims", [False, True])
def test_empty_kept_dim(self, keepdims):
a = numpy.empty((0, 3, 4))
ia = dpnp.array(a)

result = dpnp.median(ia, axis=(1, 2), keepdims=keepdims)
assert result.shape == out_shape
if numpy_version() >= "2.5.4":
expected = numpy.median(a, axis=(1, 2), keepdims=keepdims)
assert_dtype_allclose(result, expected)
expected = numpy.median(a, axis=(1, 2), keepdims=keepdims)
assert_dtype_allclose(result, expected)

@pytest.mark.parametrize("dtype", get_all_dtypes())
@pytest.mark.parametrize(
Expand Down
Loading