Repository navigation
Add an OAuth client for the FAF Rust Client - #335
Merged
Merged
Conversation
The Rust client has been signing in with the Python client's id. Give it its own entry, copied field for field from the Python one (same scopes, the same loopback redirects, public PKCE client); only the name and the id differ. The Python entry stays: released Rust clients keep using it until they update.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sheikah45
pushed a commit
that referenced
this pull request
Oct 6, 2026
The Rust client has been signing in with the Python client's id. Give it its own entry, copied field for field from the Python one (same scopes, the same loopback redirects, public PKCE client); only the name and the id differ. The Python entry stays: released Rust clients keep using it until they update.
TimMasalme
added a commit
to FAForeverRustClient/FAForeverRustClient
that referenced
this pull request
Oct 7, 2026
FAForever/gitops-stack#335 registered "FAF Rust Client" with Hydra (03c2132b-b5f8-4cbd-9901-499e83700f45), so the client no longer has to borrow the Python client's id, and FAF retiring that client no longer locks every user out. Hydra binds a refresh token to the client that obtained it and refuses to renew it under any other id. Swapping the id alone would therefore have signed out every user who ticked "Remember me" on the first launch of the update. The keyring entry now records the issuing client next to the token, and both the restore and the background renewal use that client. A bare token from before this change is read as the Python client's, keeps renewing under it, and the user moves to the new id at their next interactive login. (cherry picked from commit 0aaafda)
NoryGit
pushed a commit
to NoryGit/FAForever-Rust-Client
that referenced
this pull request
Oct 8, 2026
FAForever/gitops-stack#335 registered "FAF Rust Client" with Hydra (03c2132b-b5f8-4cbd-9901-499e83700f45), so the client no longer has to borrow the Python client's id, and FAF retiring that client no longer locks every user out. Hydra binds a refresh token to the client that obtained it and refuses to renew it under any other id. Swapping the id alone would therefore have signed out every user who ticked "Remember me" on the first launch of the update. The keyring entry now records the issuing client next to the token, and both the restore and the background renewal use that client. A bare token from before this change is read as the Python client's, keeps renewing under it, and the user moves to the new id at their next interactive login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FAF Rust Client has been signing in with the Python client's OAuth client (
95ecec08-…). This gives it its own.The entry is a copy of "FAF Classic Client (Python)", field for field. The Rust client already requests exactly those scopes and uses the same loopback redirect (
http://127.0.0.1:<ephemeral port>, RFC 8252), so only the name and the id differ:03c2132b-b5f8-4cbd-9901-499e83700f45(a fresh random UUID)tokenEndpointAuthMethod: "none", no secretOrder of rollout:
Checked with
helm template apps/ory-hydraagainstconfig/prod.yaml: the new client shows up in the client-creation job like the others.