Skip to content

Vmxm reprocessing patch - #393

Merged
amyjaynethompson merged 3 commits into
mainfrom
vmxm_reprocessing_patch
Oct 6, 2026
Merged

amyjaynethompson merged 3 commits into
mainfrom
vmxm_reprocessing_patch

Conversation

@amyjaynethompson

@amyjaynethompson amyjaynethompson commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes two small bugs VMXm found when using multiplex_filtering.

  1. Their requested default image batch size wasn't being used (this was due to using '-' instead of '_' in the pydantic model). This has now been fixed by removing alias as not needed.
  2. The ISPyB query was grabbing all original job parameters - however instead of overwriting new ones, it duplicated them. This was causing the multiplex_filtering pipeline to crash. This has been fixed by checking for which parameters from the original job had been declared in the reprocessing and removing those.

@amyjaynethompson
amyjaynethompson merged commit f170c74 into main Oct 6, 2026
1 check passed
@amyjaynethompson
amyjaynethompson deleted the vmxm_reprocessing_patch branch October 6, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant