Repository navigation
Push: device-token lifecycle (POST /api/push/register / DELETE /api/push/unregister) #46
Description
Activity
Implemented in #106 (branch
issue/46-push-token-lifecycle). Closing here — review and any follow-up happens on the PR.This was filed as blocked behind #45, but only the token source actually is.
/help/api/push-notificationsdocuments the server contract in full and I confirmed live thatPOST /api/push/registeris bearer-authenticated and thatplatformacceptsandroid— so the whole lifecycle is buildable and testable now, with the FCM token behind aPushTokenProviderseam. No Firebase plugin or dependency was added; landing #45 is a single binding swap.The security-relevant half is the part worth reviewing: unregister-on-sign-out hangs off
AuthRepository.logout()via aSessionTeardownTaskmultibinding, run before the session token is cleared, so no sign-out path can bypass it — including account deletion, which already routes through the same method. A stale token would otherwise deliver one account's notifications to a device someone else has since signed in on.POST_NOTIFICATIONSis asked when the user turns on a Push channel in Notification preferences rather than at cold start. Consequence worth knowing: a user who never visits that screen is never asked, so on Android 13+ the existing poll's tray notifications stay silent for them.
Part of #44 — Push notifications: real device push (FCM) to replace the WorkManager poll
account land on a device someone else is now signed in on.
POST_NOTIFICATIONSat a moment that earns the grant rather than on cold start, andkeep the app fully functional when it is denied.
:feature:authrather than adding a newone.
Tests: register on new token; unregister on sign-out; denied-permission path.
Filed from the parity review of
feature/parity-wip@14d7795against interlinedlist.com (OpenAPI/api/openapi.json, 233 paths) and the public help centre.