Repository navigation
Settings: theme preference synced to the account (theme) #36
Description
Activity
Implemented in the PR above (branch
issue/36-settings-theme). Closing here — review and any follow-up happens on the PR.Server-side finding worth acting on independently:
themeis not validated at all.PATCH /api/user/updateaccepted and stored"not-a-theme","sepia","SYSTEM"and"", each answering200 {"message":"User updated successfully"}. CompareviewingPreference, which returns a proper allow-list in its 400. Any client can put the account into a theme no client can render. The app is therefore the conservative side — it sends onlylight/dark/systemand refuses to adopt an unrenderable stored value rather than silently overwriting it. The test account was left as found (light).The vocabulary came from
/help/settingsinstead: "Theme: Light, dark, or system (follows your device preference)" — so the account does have a follow-the-system option, andThemeMode.SYSTEMmaps straight to"system"with no coercion.The reconciliation rule the issue asked me to define and test: an unsynced local choice wins; otherwise the account wins. Neither side has a modification timestamp, so "newest wins" was unavailable — but a persisted unsynced flag is happened-after evidence, since a change that never reached the account means the account still holds whatever preceded it.
- added a commit that references this issue
on Sep 16, 2026
Part of #31 — Settings & preferences parity — most of
PATCH /api/user/updateis unreachable from AndroidDark mode already works locally via
ThemeSettingsStore/ThemeModein:core:datastore,but the choice is device-local. The account carries a
themefield onPATCH /api/user/update,so a user who sets dark on the web still lands in light on a fresh Android install.
theme, and adopt the account value on first sign-in.Tests: local → PATCH; account value applied at sign-in; offline change survives and syncs.
Filed from the parity review of
feature/parity-wip@14d7795against interlinedlist.com (OpenAPI/api/openapi.json, 233 paths) and the public help centre.