Repository navigation
[PWGCF] lambdaSpinPolarization.cxx: fix clang-tidy code-check errors from the previous version - #18229
Merged
Conversation
…Physics/code-check (clang-tidy) result came in. It fixes the 5 errors and 12 warnings reported there 1. Removed three unused includes (ASoAHelpers.h, BinningPolicy.h, TH2.h). 2. Changed the floating-point loop counter for the ME pool-size axis edges to an integer one. 3. Moved the widening cast in the pool count to before the multiplication. 4. Removed redundant member initializers, used designated initializers, made a pointer check explicit, and replaced a static_cast downcast with dynamic_cast. No change in behavior: the axis edges, pool count and every condition are the same as before.
subhadee-ali
requested review from
alibuild,
dsarkaralice,
jaelpark,
lauraser,
victor-gonzalez and
wenyaCern
as code owners
October 9, 2026 03:42
|
O2 linter results: ❌ 0 errors, |
dsarkaralice
enabled auto-merge (squash)
October 9, 2026 04:32
dsarkaralice
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18228, which was merged before the build/O2Physics/code check (clang-tidy) result came in. It fixes the 5 errors and 12 warnings reported there