Skip to content

[Common] Generalise navigation of mother indices for MC truth matching - #18222

Open
fgrosa wants to merge 10 commits into
AliceO2Group:masterfrom
fgrosa:mctruth
Open

fgrosa wants to merge 10 commits into
AliceO2Group:masterfrom
fgrosa:mctruth

Conversation

@fgrosa

@fgrosa fgrosa commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

This PR generalises the navigation through the mother indices. So far it was always assumed that the index of mother1 is smaller than mother2, and all the particles between mother1 and mother2 are mothers, but this is not always the case for instance in PYTHIA for partonic processes

image

This PR should take all the cases in account properly. It has been tested for charm hadrons and verified that the correct origin is tagged in this way.

@github-actions github-actions Bot changed the title Generalise navigation of mother indices for MC truth matching [Common,PWGHF] Generalise navigation of mother indices for MC truth matching Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 9 disabled

@github-actions github-actions Bot removed the pwghf PWG-HF label Oct 8, 2026
@fgrosa fgrosa changed the title [Common,PWGHF] Generalise navigation of mother indices for MC truth matching [Common] Generalise navigation of mother indices for MC truth matching Oct 8, 2026
dsekihat
dsekihat previously approved these changes Oct 8, 2026
@dsekihat
dsekihat enabled auto-merge (squash) October 8, 2026 15:32
@vkucera

vkucera commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Thanks @fgrosa !

@fgrosa

fgrosa commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @dsekihat @vkucera for the very fast reaction! It's indeed good to fix this, I just have realised now that I could add one more protection that is useful in some corner cases of particles that are mothers of themselves (7598b12). Could you please reapprove? Thanks again!

@alibuild

alibuild commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 7598b12 at 2026-10-08 18:22:

No log files found

Full log here.

@alibuild

alibuild commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 7598b12 at 2026-10-08 18:22:

No log files found

Full log here.

@alibuild

alibuild commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7598b12 at 2026-10-08 18:23:

No log files found

Full log here.

@dsekihat
dsekihat disabled auto-merge October 8, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants