Repository navigation
Conversation
fgrosa
requested review from
a team,
NicoleBastid,
alibuild,
apalasciano,
ddobrigk,
deepathoms,
dsekihat,
fcatalan92,
fcolamar,
gluparel,
hahassan7,
iarsene,
jgrosseo,
jpxrk,
ktf,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
October 8, 2026 15:26
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#18222
dsekihat
previously approved these changes
Oct 8, 2026
dsekihat
enabled auto-merge (squash)
October 8, 2026 15:32
Collaborator
|
Thanks @fgrosa ! |
Collaborator
Author
dsekihat
approved these changes
Oct 8, 2026
Collaborator
Collaborator
Collaborator
dsekihat
disabled auto-merge
October 8, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalises the navigation through the mother indices. So far it was always assumed that the index of mother1 is smaller than mother2, and all the particles between mother1 and mother2 are mothers, but this is not always the case for instance in PYTHIA for partonic processes
This PR should take all the cases in account properly. It has been tested for charm hadrons and verified that the correct origin is tagged in this way.