Skip to content

[PWGJE] fixing code cheker errors in embedding - #18211

Merged
nzardosh merged 1 commit into
AliceO2Group:masterfrom
nzardosh:embeddingFinal
Oct 8, 2026
Merged

nzardosh merged 1 commit into
AliceO2Group:masterfrom
nzardosh:embeddingFinal

Conversation

@nzardosh

@nzardosh nzardosh commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgje label Oct 8, 2026
@github-actions github-actions Bot changed the title fixing code cheker errors in embedding [PWGJE] fixing code cheker errors in embedding Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 47 warnings, 🔕 0 disabled

@nzardosh
nzardosh enabled auto-merge (squash) October 8, 2026 07:18
alibuild
alibuild previously approved these changes Oct 8, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @nzardosh.

@alibuild

alibuild commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6854a17 at 2026-10-08 10:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 8 warnings.'
Found 6 errors and 8 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/d495817417f4e0583ccaa46c7804945a11fcd8dc/O2Physics-code-check/errors.txt
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:58: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:36:103: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:56:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:62:28: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:70:92: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:118:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/d495817417f4e0583ccaa46c7804945a11fcd8dc/O2Physics-code-check/warnings.txt
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:91:8: warning: constructor does not initialize these fields: ccdb, lut, pdgDatabase, runNumber, hadronicRate, withCollisionAssociator [cppcoreguidelines-pro-type-member-init]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:611:15: warning: variable 'sigmaDCAXYZ2' is not initialized [cppcoreguidelines-init-variables]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:636:17: warning: variable 'sigmaDCAXYZ2' is not initialized [cppcoreguidelines-init-variables]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:728:17: warning: variable 'sigmaDCAXYZ2' is not initialized [cppcoreguidelines-init-variables]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:749:17: warning: variable 'sigmaDCAXYZ' is not initialized [cppcoreguidelines-init-variables]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:803:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGJE/Tasks/embeddingQA.cxx:105:12: warning: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/embeddingQA.cxx:110:11: warning: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @nzardosh.

@nzardosh
nzardosh merged commit a56ac65 into AliceO2Group:master Oct 8, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants