You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PWGHF] taskFlow.cxx : fix centrality, fix mcGen, add outer and inner FT0 selections and other small changes - #18203
github-actionsBot
changed the title
taskFlow.cxx : fix centrality, fix mcGen, add outer and inner FT0 selections and other small changes
[PWGHF] taskFlow.cxx : fix centrality, fix mcGen, add outer and inner FT0 selections and other small changes
Oct 7, 2026
@AlexianL I noticed that you fix the formatting issues with additional commits. Please note that this can be fully automated with the pre-commit hook or you can just merge the formatting PR, as explained in the contribution guidelines.
@AlexianL I noticed that you fix the formatting issues with additional commits. Please note that this can be fully automated with the pre-commit hook or you can just merge the formatting PR, as explained in the contribution guidelines.
Hi, thanks for the reminder! I knew about them but I forgot to install the pre-commit hook after I re-installed O2Physics completely few days ago
Error while checking build/O2Physics/code-check for 621b4f6 at 2026-10-07 22:43:
## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 42 warnings.'
Found 1 errors and 42 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/6ef5b47eddeef6d10731b2772c6f72d8b5303f77/O2Physics-code-check/errors.txt
PWGHF/HFC/Tasks/taskFlow.cxx:1925:15: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
++ [[ 42 -gt 0 ]]
++ cat /sw/BUILD/6ef5b47eddeef6d10731b2772c6f72d8b5303f77/O2Physics-code-check/warnings.txt
PWGHF/HFC/Tasks/taskFlow.cxx:117:1: warning: initial values in enum 'FT0InnerOrOuter' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGHF/HFC/Tasks/taskFlow.cxx:199:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:200:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:201:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:202:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:203:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:218:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:311:59: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskFlow.cxx:370:35: warning: initializer for member 'cstFT0RelGain' is redundant [readability-redundant-member-init]
PWGHF/HFC/Tasks/taskFlow.cxx:537:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:549:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:567:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:623:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:633:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:835:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:893:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:926:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:983:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:1326:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:1341:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:1361:60: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1368:60: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1375:60: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1382:58: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1460:23: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:1790:23: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:2026:23: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:2223:23: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:2492:23: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:2643:23: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:2711:23: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:2843:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:2905:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:2969:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:3040:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:3132:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:3403:22: warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:4173:22: warning: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions]
PWGHF/HFC/Tasks/taskFlow.cxx:4565:24: warning: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions]
[0 more errors; see full log]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.