Skip to content

[PWGHF] First draft of Omegac0 to OmegaPi QA workflow - #18126

Merged
fcatalan92 merged 17 commits into
AliceO2Group:masterfrom
mtorresc15:omegac0-qa
Oct 8, 2026
Merged

fcatalan92 merged 17 commits into
AliceO2Group:masterfrom
mtorresc15:omegac0-qa

Conversation

@mtorresc15

Copy link
Copy Markdown
Contributor

First draft of the QA workflow for the Omegac0 to OmegaPi analysis.

This PR introduces dedicated QA versions of the candidate selector, tree creator, analysis task, and ML response to allow a more detailed validation of the Omegac0 to OmegaPi analysis workflow.

The main additions are:

  • Candidate selector: QA monitoring of the selection steps, with dedicated DCAFitter and KFParticle processing.
  • Tree creator: dedicated QA output tables containing additional reconstruction and selection information for DCAFitter and KFParticle candidates.
  • ML response: common and reconstruction-specific ML input features for both DCAFitter and KFParticle.
  • Analysis task: processing DCAFitter and KFParticle candidates, with and without ML selections.

The implementation is based on the existing Omegac0 to OmegaPi analysis workflow and is intended to facilitate validation and comparison of the DCAFitter and KFParticle reconstruction and selection strategies.

This PR is opened as a draft for preliminary review and feedback.

@github-actions github-actions Bot added the pwghf PWG-HF label Sep 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title First draft of Omegac0 to OmegaPi QA workflow [PWGHF] First draft of Omegac0 to OmegaPi QA workflow Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new executables lack build registration, and selector issues can alter cuts or fatally terminate ML workflows.

Review effort: Balanced
Findings: 4 High severity · 2 Medium severity · 1 Low severity

Open (7)
What changed in this PR

Adds QA workflows for comparing DCAFitter and KFParticle Ωc⁰→Ωπ reconstruction.

Changes:

  • Adds QA candidate selection and output trees.
  • Adds reconstruction-specific ML features.
  • Adds data/MC analysis modes with optional ML and centrality.
File Description
PWGHF/​TableProducer/​treeCreatorOmegac0ToOmegaPiQa.cxx Defines detailed QA output tables.
PWGHF/​TableProducer/​candidateSelectorOmegac0ToOmegaPiQa.cxx Implements selection, PID, ML, and QA monitoring.
PWGHF/​D2H/​Tasks/​taskOmegac0ToOmegaPiQa.cxx Adds data and MC analysis modes.
PWGHF/​Core/​HfMlResponseOmegacToOmegaPiQa.h Defines DCAFitter and KFParticle ML features.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread PWGHF/D2H/Tasks/taskOmegac0ToOmegaPiQa.cxx
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx
Comment thread PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h Outdated
Comment thread PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx
Comment thread PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx
@fcatalan92
fcatalan92 marked this pull request as ready for review October 7, 2026 15:24
@vkucera

vkucera commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

@mtorresc15 Please fix the warnings.

@alibuild

alibuild commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bfe3dab at 2026-10-08 15:49:

No log files found

Full log here.

@fcatalan92
fcatalan92 enabled auto-merge (squash) October 8, 2026 15:11
@alibuild

alibuild commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for b4bf9ad at 2026-10-08 18:13:

No log files found

Full log here.

@fcatalan92
fcatalan92 merged commit dc2a2df into AliceO2Group:master Oct 8, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

5 participants