Repository navigation
Conversation
Add an option to compute the checksum of dumped data on the fly when using --debug 6. Only prints the checksum instead of writing dumped data to file when this option is used.
davidrohr
requested changes
Oct 8, 2026
| AddOption(allocDebugLevel, int32_t, 0, "allocDebug", 0, "Some debug output for memory allocations (without messing with normal debug level)") | ||
| AddOption(debugMask, uint32_t, (1 << 18) - 1, "debugMask", 0, "Mask for debug output dumps to file") | ||
| AddOption(debugLogSuffix, std::string, "", "debugSuffix", 0, "Suffix for debug log files with --debug 6") | ||
| AddOption(debugDumpChecksum, bool, false, "", 0, "Dump the only the checkusm instead of the full file with --debug 6") |
Collaborator
There was a problem hiding this comment.
Please fix the english in the description :)
| message(FATAL_ERROR "Cannot build event display without ROOT") | ||
| endif() | ||
| find_package(Microsoft.GSL REQUIRED HINTS "$ENV{MS_GSL_ROOT}/share/cmake") | ||
| find_package(Boost 1.88 REQUIRED) # boost/hash2 (HashStreamBuf.h) |
Collaborator
There was a problem hiding this comment.
The standalone benchmark should not be force to depend on boost. Isn't there a way to do this with modern C++?
Otherwise, the Boost dependency should be optional, and the functionality disabled if boost is not found.
Contributor
Author
There was a problem hiding this comment.
I'm not aware of anything in the C++ standard library that provides this. We could just include xxhash.h (single header library, C implementation) for the hashing algorithm and get rid of the boost dependency. But I'm not sure what the policy is on including external sources directly in O2.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to compute the checksum of dumped data on the fly when using --debug 6. Only prints the checksum instead of writing dumped data to file when this option is used.