diff --git a/tests/parseutils/test_parseutils.py b/tests/parseutils/test_parseutils.py index 02341125f..d1221f86e 100644 --- a/tests/parseutils/test_parseutils.py +++ b/tests/parseutils/test_parseutils.py @@ -106,7 +106,6 @@ def test_simple_insert_single_table(): assert tables == ((None, "abc", "abc", False),) -@pytest.mark.xfail def test_simple_insert_single_table_schema_qualified(): tables = extract_tables('insert into abc.def (id, name) values (1, "def")') assert tables == (("abc", "def", None, False),) diff --git a/tests/test_sqlcompletion.py b/tests/test_sqlcompletion.py index 9deb3455d..20abb99a9 100644 --- a/tests/test_sqlcompletion.py +++ b/tests/test_sqlcompletion.py @@ -450,7 +450,12 @@ def test_sub_select_col_name_completion(): } -@pytest.mark.xfail +@pytest.mark.xfail( + reason="Parsing an incomplete multi-column sub-select still misidentifies the " + "token before the trailing comma as a table: 'SELECT a, FROM abc' yields " + "table_refs for both 'a' and 'abc' instead of just 'abc'. Confirmed still " + "failing on sqlparse 0.6.0." +) def test_sub_select_multiple_col_name_completion(): suggestions = suggest_type("SELECT * FROM (SELECT a, FROM abc", "SELECT * FROM (SELECT a, ") assert set(suggestions) == cols_etc("abc")